Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query string authentication for API calls #2329

Merged
merged 1 commit into from
Sep 4, 2022
Merged

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?:

Closes #2326

How does this PR accomplish the above?:

Passing the api flag to the password verification function.

What documentation changes (if any) are needed to support this PR?:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign changed the title Check if the API call was made using the query string authentication Fix query string authentication for API calls Sep 3, 2022
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pihole-api-and-tasmota/57544/2

@PromoFaux
Copy link
Member

Looks Gouda to me

@PromoFaux PromoFaux merged commit d68d5ee into devel Sep 4, 2022
@PromoFaux PromoFaux deleted the fix/api_auth branch September 4, 2022 12:27
@jojost1
Copy link

jojost1 commented Sep 4, 2022

@PromoFaux Any word on when this fix can be released? I would really appreciate if this could be hotfixed (the bug breaks all authenticated API calls and therefore many third party Pi-hole utilities) but I don't know how you decide if it's worth to hotfix something 😄

@PromoFaux
Copy link
Member

No reason why it can't go out today, just waiting for another couple of pairs of eyes on it from the team before I hit the buttons!

#2332

@jojost1
Copy link

jojost1 commented Sep 4, 2022

I appreciate it! ❤️

@baderdj
Copy link

baderdj commented Sep 4, 2022

Looks like server stats aren't allowed with this patch. Things like Temperature, CPU, Memory show an error while fetching data.

@PromoFaux
Copy link
Member

Things like Temperature, CPU, Memory show an error while fetching data.

This is expected: #2332 (comment)

@baderdj
Copy link

baderdj commented Sep 4, 2022

Things like Temperature, CPU, Memory show an error while fetching data.

This is expected: #2332 (comment)

oh ok. Not a huge miss but it was nice to see on the Pi-hole Remote app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants