-
-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix query string authentication for API calls #2329
Conversation
a8d0180
to
e9cf03c
Compare
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
e9cf03c
to
a55ae95
Compare
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pihole-api-and-tasmota/57544/2 |
Looks Gouda to me |
@PromoFaux Any word on when this fix can be released? I would really appreciate if this could be hotfixed (the bug breaks all authenticated API calls and therefore many third party Pi-hole utilities) but I don't know how you decide if it's worth to hotfix something 😄 |
No reason why it can't go out today, just waiting for another couple of pairs of eyes on it from the team before I hit the buttons! |
I appreciate it! ❤️ |
Looks like server stats aren't allowed with this patch. Things like Temperature, CPU, Memory show an error while fetching data. |
This is expected: #2332 (comment) |
oh ok. Not a huge miss but it was nice to see on the Pi-hole Remote app. |
What does this PR aim to accomplish?:
Closes #2326
How does this PR accomplish the above?:
Passing the api flag to the password verification function.
What documentation changes (if any) are needed to support this PR?:
none
By submitting this pull request, I confirm the following:
git rebase
)