Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show link from query log to domain table for black/whitelisted domains #2346

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Show link from query log to domain table for black/whitelisted domains #2346

merged 1 commit into from
Sep 12, 2022

Conversation

jpgpi250
Copy link
Contributor

jpgpi250 jpgpi250@gmail.com

accompanies FTL PR 1409

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions

  • What does this PR aim to accomplish?:

accompanies FTL PR 1409

  • How does this PR accomplish the above?:

additional field evaluated for all queries (used to be status 4 & 10 only

  • What documentation changes (if any) are needed to support this PR?:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

jpgpi250 <jpgpi250@gmail.com>

accompanies FTL PR 1409
@jpgpi250
Copy link
Contributor Author

jpgpi250 commented Sep 12, 2022

third and last attempt to get it.

sorry for waisting your time...

@yubiuser yubiuser changed the title Update queries.js Show link from query log to domain table Sep 12, 2022
@yubiuser
Copy link
Member

sorry for waisting your time...

No reason for self-pity. We all started somewhere

@yubiuser yubiuser changed the title Show link from query log to domain table Show link from query log to domain table for black/whitelisted domains Sep 12, 2022
@yubiuser yubiuser merged commit a73be14 into pi-hole:devel Sep 12, 2022
@jpgpi250 jpgpi250 deleted the devel branch September 12, 2022 11:12
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-18-web-v5-15-and-core-v5-12-1-released/57894/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants