Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update momentjs to 2.29.4 #2399

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Update momentjs to 2.29.4 #2399

merged 1 commit into from
Oct 28, 2022

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Update momentjs to the latest version 2.29.4


Moment considers itself

We now generally consider Moment to be a legacy project in maintenance mode. It is not dead, but it is indeed done.

https://momentjs.com/docs/

I looked for a replacement (e.g. luxon) which moment recommends, but failed at daterangepicker which needs momentjs internally. daterangepicker itself also looks like a "legancy project" (last release 2 years ago), but I could not find a suitable replace with the same feature set.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser added Requires Testing PR: Approval Required Open Pull Request, needs approval labels Oct 13, 2022
@yubiuser yubiuser requested a review from a team October 13, 2022 15:50
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any issues with "this project is done" - it just offers anything you'd want. I also interpret this as: "If there are serious security issues, we will fix them"

Again, testing showed no obvious oddities - ready for merging into devel IMO

@DL6ER DL6ER merged commit bc6f9fd into devel Oct 28, 2022
@DL6ER DL6ER deleted the momentjs branch October 28, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval Requires Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants