Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent CNAME loops #2407

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Prevent CNAME loops #2407

merged 1 commit into from
Oct 20, 2022

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?

Fix #2406

How does this PR accomplish the above?

Making sure domain and target are different.

What documentation changes (if any) are needed to support this PR?

none

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@rdwebdesign
Avoid cname loops
ebaf415 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign
Copy link
Member Author

Fixed.

image

Now a message will be shown if target and domain are equal.

@rdwebdesign rdwebdesign requested a review from a team October 20, 2022 05:53
@rdwebdesign rdwebdesign reopened this Oct 20, 2022
@rdwebdesign
Copy link
Member Author

I closed/reopened the PR to re-run all tests (some of them were stuck).

@yubiuser
Copy link
Member

DCO got stuck and I can't find the "override DCO" button.... I know there is one.

@rdwebdesign rdwebdesign enabled auto-merge (rebase) October 20, 2022 19:27
@rdwebdesign rdwebdesign merged commit 39f23fd into devel Oct 20, 2022
@rdwebdesign rdwebdesign deleted the equal_cname_loop branch October 20, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yubiuser yubiuser yubiuser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdwebdesign @yubiuser