-
-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide fake username on login form #2419
Conversation
3ed77e5
to
d836c20
Compare
Note to self: get rid of Chrome's autofill CSS modifications of the input box |
This PR will solve the issue, but I think this is a browser bug introduced recently. To be sure, I tested using the current browser version and 2 different Pi-hole versions (docker image latest and 2022.02) and the password is not saved in both cases. Without your PR, I was able to save the password on both browsers using the normal procedure, but I needed to type an username:
|
Do you think I should not proceed with this PR as this is an external "bug" (and we could simply wait until they fix it)? Maybe they don't see this as a bug, but as a feature and won't fix it ever? |
Signed-off-by: Christian König <ckoenig@posteo.de>
0023c96
to
7a44381
Compare
Signed-off-by: Christian König <ckoenig@posteo.de>
Ready for review. I adjusted the CSS to overwrite the auto-fill style on Chrome browsers. |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-20-1-web-v5-18-1-and-core-v5-15-released/60495/1 |
What does this PR aim to accomplish?:
When a password is set for the web interface, we use
autocomplete="current-password"
on the password login form to allow browsers and password managers to auto-fill the input field. This works well with e.g. Firefox, but fails on Chrome (see #2418).To fix this, we add a hidden input field providing a fake username (
pi.hole
).By submitting this pull request, I confirm the following:
git rebase
)