Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group editing #2922

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Fix group editing #2922

merged 1 commit into from
Jan 17, 2024

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jan 6, 2024

What does this implement/fix?

Fix editing of groups not being possible. We need to use the group name's for the REST API, not their database ID. We encode the names for safety as users could have used conflicting characters in groups names. This is not new altogether - we do the same for lists as they are allowed to contain / which obviously have some meaning in URLs.


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team January 6, 2024 08:32
@DL6ER
Copy link
Member Author

DL6ER commented Jan 6, 2024

@yubiuser
Copy link
Member

yubiuser commented Jan 6, 2024

Works fine now, before editing was not possible.

Should we add the name of the group to the notification as we have it for adding/deleting?

Screenshot at 2024-01-06 12-36-49
Screenshot at 2024-01-06 12-37-04

@DL6ER DL6ER merged commit 0c1b44e into development-v6 Jan 17, 2024
7 checks passed
@DL6ER DL6ER deleted the fix/group_edit branch January 17, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants