Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign domain search input field #2957

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 12, 2024

What does this implement/fix?

Before

Screenshot from 2024-02-12 12-35-50

Now

Screenshot from 2024-02-12 12-38-21

Related issue or feature (if applicable): Fixes #2701

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@rdwebdesign
Copy link
Member

rdwebdesign commented Feb 13, 2024

Now that you changed the design to use a single button with shorter text, you can remove these CSS rules:

web/style/pi-hole.css

Lines 565 to 577 in 938c6ef

#domain-search-block {
display: block;
}
#domain {
margin: 5px 0;
}
#domain-search-block .input-group-btn {
display: inline-block;
}
#domain-search-block .input-group-btn button {
margin: 0 5px 0 0;
border-radius: 3px;
}

EDIT:
After out conversation, I added a commit to remove the unused CSS.

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
- use 4-8 columns instead of 6-6;
- use label before the number control (this will show the label on the previous line, when there is a line break);
- right-align second column in larger screens and add small margin;
- remove old HTML comments.

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign force-pushed the tweak/partial_matching branch from 2427ff6 to 0854c2a Compare February 13, 2024 18:29
Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK

@DL6ER DL6ER merged commit fb30ea9 into development-v6 Mar 7, 2024
8 checks passed
@DL6ER DL6ER deleted the tweak/partial_matching branch March 7, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tools > Search adlists has not obvious default behaviour when pressing Enter inside textbox
3 participants