Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings Pages - small adjustments #3000

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Settings Pages - small adjustments #3000

merged 3 commits into from
Apr 3, 2024

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?

Some elements are missing classes, misaligned, using the wrong format, etc.

Before:
image

After:
image

How does this PR accomplish the above?:

Adding many small adjustments to settings pages.

Link documentation PRs if any are needed to support this PR:

none

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.
  • I have read the above and my PR is ready for review. Check this box to confirm

@rdwebdesign
Fix buttons in high contrast themes
a8098e8 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign marked this pull request as draft April 2, 2024 20:12
@rdwebdesign rdwebdesign marked this pull request as ready for review April 2, 2024 22:18
@rdwebdesign rdwebdesign requested a review from a team April 2, 2024 22:20
@rdwebdesign
Settings Page - Apply small adjustments
6f65368 
- consistent indentation and widths for fields and labels
- use class `form-control` to format every form field
- add some line breaks to improve readability

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign
Use colors in Currently active sessions table
172e4ea 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign force-pushed the settings_small_fixes branch from 806f694 to 172e4ea Compare April 3, 2024 00:29
DL6ER
DL6ER approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, e.g.

Screenshot from 2024-04-03 04-29-45

One more for the list of future fixes maybe:

grafik

Screenshot from 2024-04-03 04-30-13

Select labels could be vertically centered as well (as are checkbox labels already now).

@rdwebdesign rdwebdesign merged commit f842c72 into development-v6 Apr 3, 2024
8 checks passed
@rdwebdesign rdwebdesign deleted the settings_small_fixes branch April 3, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DL6ER DL6ER DL6ER approved these changes

Assignees
No one assigned
Labels
Pi-hole v6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdwebdesign @DL6ER