Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible race condition in Top Lists #3061

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jul 1, 2024

What does this implement/fix?

Fix possible race condition on page load of the index page. This is a recent regression by #3058

Reported on Discourse https://discourse.pi-hole.net/t/double-and-duplicate-items-in-all-the-top-categories/70969


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

… recent regression

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team July 1, 2024 15:36
@DL6ER DL6ER merged commit 9d39d6f into development-v6 Jul 2, 2024
7 checks passed
@DL6ER DL6ER deleted the fix/doubleTables branch July 2, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants