Fix the "title" attribute to show all IPs/hostnames #3098
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?
Fix the tooltip used on the network table when there are more than 3 IPs/hostnames.
Related to: https://discourse.pi-hole.net/t/tools-network-limited-to-3-hostnames-and-ips-hover-not-working/71512
How?
The original code used to add the text to the title was adding the text on
hover
, but this was broken some time ago, when jquery warnings where fixed.Also, dynamically adding the title "on hover" is not the best way to do it.
Now the title is added to the element at the same time we add the links.
Link documentation PRs if any are needed to support this PR:
None
By submitting this pull request, I confirm the following:
git rebase
)