Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "title" attribute to show all IPs/hostnames #3098

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?

Fix the tooltip used on the network table when there are more than 3 IPs/hostnames.

Related to: https://discourse.pi-hole.net/t/tools-network-limited-to-3-hostnames-and-ips-hover-not-working/71512

How?

The original code used to add the text to the title was adding the text on hover, but this was broken some time ago, when jquery warnings where fixed.
Also, dynamically adding the title "on hover" is not the best way to do it.

Now the title is added to the element at the same time we add the links.

Link documentation PRs if any are needed to support this PR:

None


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign merged commit b1fd8fd into development-v6 Aug 9, 2024
8 checks passed
@rdwebdesign rdwebdesign deleted the fix/network_table branch August 9, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants