Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify system setting modal buttons #3118

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Unify system setting modal buttons #3118

merged 1 commit into from
Aug 26, 2024

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Unifies the colors of the buttons on the modal appearing after clicking one of the four 'danger' system setting buttons.
They now all use those colors:
Screenshot at 2024-08-26 22-49-13

How does this PR accomplish the above?:

Fixes #3117


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
Signed-off-by: yubiuser <github@yubiuser.dev>
@yubiuser yubiuser requested a review from a team August 26, 2024 20:53
Copy link
Member

@rdwebdesign rdwebdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As internally discussed, inside these 4 confirmation windows:

  • confirmation buttons should use the same color and
  • cancel buttons should use the default button color.

The colors (yellow/red) of the external triggering buttons are related only to the button meaning/action and doesn't need to match the colors of the internal buttons.

@yubiuser yubiuser merged commit c68e05c into development-v6 Aug 26, 2024
7 checks passed
@yubiuser yubiuser deleted the button/color branch August 26, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants