-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to assign groups to newly added entries from the beginning #3187
Conversation
…nning Signed-off-by: DL6ER <dl6er@dl6er.de>
…quotes Signed-off-by: DL6ER <dl6er@dl6er.de>
cfa26d5
to
f91e8a0
Compare
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
57306bc
to
6ab55c4
Compare
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is on purpose, but the group selector does not reset to default after a client/domain/list is added with a manually changed group selection.
Yes, this is on purpose. During playing around I found it quite counterintuitive that the field resets, e.g., when I add multiple domains but don't add them at once (space separated) because I want different comments for each of them. |
What does this implement/fix?
See the related Discourse Feature request for screenshots: https://discourse.pi-hole.net/t/add-group-management-dropdown-to-add-a-new-domain-or-regex-filter/74696
Related issue or feature (if applicable): https://discourse.pi-hole.net/t/add-group-management-dropdown-to-add-a-new-domain-or-regex-filter/74696
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.