Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker add utilities #133

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

Docker add utilities #133

wants to merge 21 commits into from

Conversation

angusjfw
Copy link
Contributor

@angusjfw angusjfw commented Oct 7, 2022

Status Ticket/Issue
Ready/Hold Ticket

Main changes

Screenshots (feature, test output, profiling, dev tools etc)

[insert screenshots here]

Other notes (e.g. implementation quirks, edge cases, questions / issues)

Manual testing tips

Tag anyone who definitely needs to review or help

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 74.85% // Head: 73.45% // Decreases project coverage by -1.40% ⚠️

Coverage data is based on head (4e734d9) compared to base (7804716).
Patch coverage: 84.61% of modified lines in pull request are covered.

❗ Current head 4e734d9 differs from pull request most recent head ff61742. Consider uploading reports for the commit ff61742 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   74.85%   73.45%   -1.41%     
==========================================
  Files          25       26       +1     
  Lines        1229     1164      -65     
==========================================
- Hits          920      855      -65     
  Misses        309      309              
Flag Coverage Δ
unittests 73.45% <84.61%> (-1.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
further_link/endpoint/status.py 61.90% <61.90%> (ø)
further_link/endpoint/run.py 83.18% <72.22%> (+0.01%) ⬆️
further_link/util/async_files.py 82.14% <82.14%> (ø)
further_link/util/id_generator.py 87.50% <83.33%> (-2.98%) ⬇️
further_link/runner/process_handler.py 84.57% <84.61%> (+0.25%) ⬆️
further_link/util/pty.py 89.58% <89.58%> (ø)
further_link/__main__.py 89.18% <100.00%> (-1.29%) ⬇️
further_link/endpoint/upload.py 100.00% <100.00%> (ø)
further_link/runner/exec_process_handler.py 93.33% <100.00%> (ø)
further_link/runner/py_process_handler.py 92.85% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@angusjfw angusjfw force-pushed the docker-add-utilities branch 2 times, most recently from 49bb2f1 to 062e141 Compare October 17, 2022 14:40
@angusjfw angusjfw force-pushed the docker-add-utilities branch 2 times, most recently from 5aaa904 to c7811c0 Compare October 27, 2022 15:26
@angusjfw angusjfw force-pushed the docker-add-utilities branch 4 times, most recently from 760b855 to b775020 Compare November 3, 2022 09:37
@angusjfw angusjfw force-pushed the docker-add-utilities branch from b775020 to 510ac4b Compare November 3, 2022 11:18
@angusjfw angusjfw force-pushed the docker-add-utilities branch 2 times, most recently from f2834cb to 15a00fd Compare November 3, 2022 14:00
@angusjfw angusjfw force-pushed the docker-add-utilities branch from 15a00fd to d7f8ff5 Compare November 3, 2022 14:37
@angusjfw angusjfw force-pushed the docker-add-utilities branch from 71431da to 605a9c9 Compare November 3, 2022 16:35
@angusjfw angusjfw force-pushed the docker-add-utilities branch from 1881bdb to 4e734d9 Compare November 4, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant