-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bluetooth connections #156
Conversation
b11d7ab
to
ea7693f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 72.83% 73.52% +0.68%
==========================================
Files 25 38 +13
Lines 1119 1760 +641
==========================================
+ Hits 815 1294 +479
- Misses 304 466 +162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ea7693f
to
7e4d2ba
Compare
|
||
# remove trailing commas | ||
message_str = re.sub(",[ \t\r\n]+}", "}", message_str) | ||
message_str = re.sub(",[ \t\r\n]+]", "]", message_str) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't really need this - the clients should send valid json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When sending as well as as chunking outgoing messages we probably need to handle buffering additional messages that are being sent while the previous one is still going out. An alternative would be to support simultaneous messages which are tagged by a message id.
Once we have finalised the chunking protocol we should add unit tests for it - we'll need to implement it in javascript and python so we want it to be pretty stable.
We discussed going with a message id approach rather than buffering. We'll drop support for unchunked messages. So chunked messages have the format: receiving logic is like:
|
a8c2c00
to
ce0da00
Compare
3724f16
to
c61de89
Compare
run steps:
|
72d3561
to
c7f6f23
Compare
20dcd75
to
dcedfe4
Compare
f27930c
to
24240f2
Compare
24240f2
to
2971468
Compare
811ca9c
to
859500c
Compare
49ae29e
to
5db75ff
Compare
6756fe8
to
ab20fb2
Compare
Also adds missing tests
22fe56b
to
45ae963
Compare
Main changes
Support bluetooth connections by adding a GATT server with a service and several characteristics to interact with the frontend app.
Screenshots (feature, test output, profiling, dev tools etc)
[insert screenshots here]
Other notes (e.g. implementation quirks, edge cases, questions / issues)
Manual testing tips
sudo apt install ./<file>
. It should automatically fetch the new dependencies from the unstable repository.Tag anyone who definitely needs to review or help