Skip to content

[WIP] 4wd controller #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

[WIP] 4wd controller #426

wants to merge 15 commits into from

Conversation

m-roberts
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #426 (78783c3) into master (854e835) will decrease coverage by 11.60%.
The diff coverage is 35.00%.

❗ Current head 78783c3 differs from pull request most recent head 98887a6. Consider uploading reports for the commit 98887a6 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master     #426       +/-   ##
===========================================
- Coverage   58.56%   46.95%   -11.61%     
===========================================
  Files          72       71        -1     
  Lines        2756     2760        +4     
===========================================
- Hits         1614     1296      -318     
- Misses       1142     1464      +322     
Flag Coverage Δ
unittests 46.95% <35.00%> (-11.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pitop/robotics/drive_controller_4wd.py 26.15% <26.15%> (ø)
pitop/robotics/drive_controller.py 86.25% <71.42%> (+1.17%) ⬆️
pitop/__init__.py 100.00% <100.00%> (ø)
pitop/robotics/pan_tilt_controller.py 27.17% <0.00%> (-32.09%) ⬇️
pitop/pma/potentiometer.py 50.00% <0.00%> (-10.00%) ⬇️
pitop/pma/servo_motor.py 34.93% <0.00%> (-8.82%) ⬇️
pitop/pma/light_sensor.py 50.00% <0.00%> (-8.34%) ⬇️
pitop/pma/sound_sensor.py 50.00% <0.00%> (-8.34%) ⬇️
pitop/core/mixins/supports_miniscreen.py 46.66% <0.00%> (-6.28%) ⬇️
pitop/core/mixins/recreatable.py 40.00% <0.00%> (-5.46%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5df5d1...98887a6. Read the comment docs.

@m-roberts m-roberts changed the title 4wd controller [WIP] 4wd controller Aug 10, 2021
@lgtm-com
Copy link

lgtm-com bot commented Aug 10, 2021

This pull request introduces 1 alert when merging 98887a6 into c5df5d1 - view on LGTM.com

new alerts:

  • 1 for First parameter of a method is not named 'self'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants