Skip to content

Weblabs server supports SSL #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcapona
Copy link
Contributor

@jcapona jcapona commented Jul 10, 2025

Status Ticket/Issue
Ready/Hold Ticket

Main changes

  • Weblabs server supports SSL by receiving a ssl_context object in its constructor.

Screenshots (feature, test output, profiling, dev tools etc)

[insert screenshots here]

Other notes (e.g. implementation quirks, edge cases, questions / issues)

Manual testing tips

Tag anyone who definitely needs to review or help

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 60.82%. Comparing base (b74cc9b) to head (d6f989c).

Files with missing lines Patch % Lines
packages/pitop/pitop/labs/web/webserver.py 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #707      +/-   ##
==========================================
- Coverage   61.12%   60.82%   -0.30%     
==========================================
  Files         163      163              
  Lines        8307     8315       +8     
==========================================
- Hits         5078     5058      -20     
- Misses       3229     3257      +28     
Flag Coverage Δ
unittests 60.82% <0.00%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jcapona jcapona force-pushed the OS-1446-weblabs-support-ssl-context branch from c8f1c61 to d6f989c Compare July 11, 2025 15:41
@jcapona jcapona marked this pull request as ready for review July 15, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant