Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add miniscreen app for onboarding #102

Merged
merged 27 commits into from
Jul 12, 2021
Merged

Add miniscreen app for onboarding #102

merged 27 commits into from
Jul 12, 2021

Conversation

jcapona
Copy link
Contributor

@jcapona jcapona commented Jul 2, 2021

The other side of pi-top/pi-top-4-Miniscreen#139

Note: this is using a placeholder GIF for AP mode. This PR is blocked until we have the assets (pi-top/pi-top-4-Miniscreen#136)

@m-roberts
Copy link
Contributor

m-roberts commented Jul 3, 2021

From what I can tell, this still need first boot logic to be ported. We should replace the FS expand breadcrumb with something more robust. One possible option would be to check the filesystem size, though I'm sure there are other ways to detect.

@jcapona jcapona force-pushed the add-miniscreen-app branch 2 times, most recently from 33db04a to 690b39d Compare July 6, 2021 21:00
@m-roberts
Copy link
Contributor

We should ensure that pt-sys-oled is not running before starting.

If there is any user code using the display and we do nothing else, the entire application will lock up because the miniscreen is considered to already be in use (See pi-top/pi-top-Python-SDK#386 for a fix for this).

Therefore, for safety, we should include the PT_MINISCREEN_SYSTEM environment variable, which prevents locking but is vulnerable to other code taking the miniscreen. This does not affect the primary pi-topOS use cases of concern.

@pi-top pi-top deleted a comment from lgtm-com bot Jul 7, 2021
@pi-top pi-top deleted a comment from lgtm-com bot Jul 7, 2021
@pi-top pi-top deleted a comment from lgtm-com bot Jul 7, 2021
@jcapona jcapona force-pushed the add-miniscreen-app branch from efdff2b to 8ce0518 Compare July 8, 2021 19:48
@m-roberts m-roberts marked this pull request as ready for review July 9, 2021 10:46
@m-roberts m-roberts marked this pull request as draft July 9, 2021 12:36
@pi-top pi-top deleted a comment from lgtm-com bot Jul 9, 2021
@pi-top pi-top deleted a comment from lgtm-com bot Jul 9, 2021
@pi-top pi-top deleted a comment from lgtm-com bot Jul 9, 2021
@pi-top pi-top deleted a comment from lgtm-com bot Jul 9, 2021
@pi-top pi-top deleted a comment from lgtm-com bot Jul 9, 2021
@m-roberts m-roberts marked this pull request as ready for review July 10, 2021 19:44
@jcapona jcapona merged commit c53d2ae into master Jul 12, 2021
@jcapona jcapona deleted the add-miniscreen-app branch July 12, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants