-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support uploading USB-setup bundle from onboarding #430
Draft
jcapona
wants to merge
5
commits into
master
Choose a base branch
from
SWE-170-offline-setup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcapona
force-pushed
the
SWE-170-offline-setup
branch
3 times, most recently
from
July 7, 2023 12:50
1b3a7c6
to
ec61686
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #430 +/- ##
==========================================
+ Coverage 69.16% 69.26% +0.10%
==========================================
Files 182 189 +7
Lines 3467 3589 +122
Branches 153 173 +20
==========================================
+ Hits 2398 2486 +88
- Misses 941 961 +20
- Partials 128 142 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
jcapona
force-pushed
the
SWE-170-offline-setup
branch
3 times, most recently
from
July 11, 2023 00:25
c207ac7
to
2957dce
Compare
jcapona
force-pushed
the
SWE-170-offline-setup
branch
from
July 11, 2023 00:25
2957dce
to
0e0c89d
Compare
jcapona
force-pushed
the
SWE-170-offline-setup
branch
from
July 19, 2023 19:42
beda0e7
to
624fb1b
Compare
jcapona
force-pushed
the
SWE-170-offline-setup
branch
from
August 28, 2023 16:45
624fb1b
to
8bce2b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes
Also, this new 'selection' page of the onboarding is skipped if we detect that the user is onboarding on the device (using a display and keyboard) or if the pi-top doesn't have an internet connection; in this case, they're redirected to the language page.
Screenshots (feature, test output, profiling, dev tools etc)
Other notes (e.g. implementation quirks, edge cases, questions / issues)
Manual testing tips
Tag anyone who definitely needs to review or help