Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install rover controller script separately #472

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Install rover controller script separately #472

merged 1 commit into from
Aug 2, 2024

Conversation

jcapona
Copy link
Contributor

@jcapona jcapona commented Aug 2, 2024

Status Ticket/Issue
Ready/Hold Ticket

Main changes

  • Install it into /usr/bin separately to avoid gevent monkey patch.

Screenshots (feature, test output, profiling, dev tools etc)

[insert screenshots here]

Other notes (e.g. implementation quirks, edge cases, questions / issues)

Manual testing tips

Tag anyone who definitely needs to review or help

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.95%. Comparing base (911293d) to head (ce6afcd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #472   +/-   ##
=======================================
  Coverage   73.95%   73.95%           
=======================================
  Files         187      187           
  Lines        4219     4219           
  Branches      437      437           
=======================================
  Hits         3120     3120           
  Misses       1098     1098           
  Partials        1        1           
Flag Coverage Δ
js-tests 85.66% <ø> (ø)
python-tests 66.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcapona jcapona marked this pull request as ready for review August 2, 2024 22:02
@jcapona jcapona merged commit f74108b into master Aug 2, 2024
11 checks passed
@jcapona jcapona deleted the rover branch August 2, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants