Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIA-1960: Update OpenVPN and update its whitelist parameters to allow for pia specific ones #11

Merged
merged 1 commit into from
Jun 20, 2024
Merged

PIA-1960: Update OpenVPN and update its whitelist parameters to allow for pia specific ones #11

merged 1 commit into from
Jun 20, 2024

Conversation

kp-juan-docal
Copy link
Contributor

@kp-juan-docal kp-juan-docal commented Jun 20, 2024 •
edited
Loading

Summary

  • It introduces the PIA-specific openvpn parameters needed for a successful DIP connection.
  • It updates the openvpn version to one supporting the above parameters.

Sanity Tests

Using a version of the library with these changes

  • On a regular VPN server. Connect to any region using Wireguard. Confirm it connects successfully.
  • On a regular VPN server. Connect to any region using OpenVPN TCP. Confirm it connects successfully.
  • On a regular VPN server. Connect to any region using OpenVPN UDP. Confirm it connects successfully.
  • On a DIP VPN server. Connect to any region using Wireguard. Confirm it connects successfully.
  • On a DIP VPN server. Connect to any region using OpenVPN TCP. Confirm it connects successfully.
  • On a DIP VPN server. Connect to any region using OpenVPN UDP. Confirm it connects successfully.

@kp-juan-docal kp-juan-docal self-assigned this Jun 20, 2024
@kp-juan-docal kp-juan-docal force-pushed the juan.docal/PIA-1960-update-openvpn-and-its-whitelist-params branch from 5b3c6a0 to fb00e9f Compare June 20, 2024 08:56
@kp-juan-docal kp-juan-docal force-pushed the juan.docal/PIA-1960-update-openvpn-and-its-whitelist-params branch from fb00e9f to 0496af5 Compare June 20, 2024 09:21
@kp-juan-docal kp-juan-docal marked this pull request as ready for review June 20, 2024 09:41
kp-stefan-klug
kp-stefan-klug approved these changes Jun 20, 2024
View reviewed changes
Copy link

@kp-stefan-klug kp-stefan-klug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kp-juan-docal kp-juan-docal merged commit 26180dd into pia Jun 20, 2024
3 checks passed
@kp-juan-docal kp-juan-docal deleted the juan.docal/PIA-1960-update-openvpn-and-its-whitelist-params branch June 20, 2024 09:52
kp-juan-docal added a commit that referenced this pull request Jun 26, 2024
@kp-juan-docal
PIA-1960: Update OpenVPN and update its whitelist parameters to allow…
20f5c3e 
… for pia specific ones (#11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kp-iva-nedeleva kp-iva-nedeleva kp-iva-nedeleva approved these changes

@kp-stefan-klug kp-stefan-klug kp-stefan-klug approved these changes

@xv-abishek-m xv-abishek-m Awaiting requested review from xv-abishek-m

Assignees

@kp-juan-docal kp-juan-docal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kp-juan-docal @kp-iva-nedeleva @kp-stefan-klug