initial prototype for returning clause #203
Closed
+52
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171
As pointed out in the above issue, there's no way to customise what the insert method returns.
We currently just return the primary key for the inserted rows.
Being able to customise what gets returned is a nice usability improvement, and in some cases could save another SELECT query.
For example:
The implementation is fairly straightforward with Postgres, but SQLite only supports the RETURNING clause in fairly recent versions (>= 3.35.0), so needs more consideration:
https://www.sqlite.org/lang_returning.html
We could also potentially add a
returns_objects
argument, which would returns the new rows as Table instances instead of a list of dictionaries.