change run_sync
#539
change run_sync
#539
Conversation
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
=======================================
Coverage 90.75% 90.76%
=======================================
Files 104 104
Lines 7011 7018 +7
=======================================
+ Hits 6363 6370 +7
Misses 648 648
Continue to review full report at Codecov.
|
Trying `asyncio.run` first, as in 99% of cases this will work. Also, using asyncio.run in a thread when running in an event loop.
This runs the tests in Python's development mode, which gives lots of useful information - for example, about deprecated features, and asyncio warnings.
When running the tests in development mode, I realised that there were situations where the connection wasn't being closed (i.e. if an exception was raised by asyncpg due to a Postgres error).
These are async first. They replace `create_tables` and `drop_tables` which were sync first, and had no async equivalent.
dantownsend
added
enhancement
|
In the end, I took another approach. It seems like The root cause of this issue was using Piccolo's
Likewise,
|
Fixes #536
We recently changed the
run_syncimplementation to avoid a Python 3.10 deprecation warning. However, it had unintended consequences, and would sometimes fail when used alongside other async code.This new implementation seems to avoid the deprecation warnings, whilst still working correctly with other async code.