Avoid Ember.inject.service() for optional i18n
#153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an object that utilizes an `Ember.inject.service()` is looked up the
first time, Ember's DI system confirms that the service being injected is
actually present and known to the system. If the service is not present
it throws an error.
In the use case of this addon, `i18n` is intended to be an optional service
and may not be present. If we use `Ember.inject.service()` in this context
we loose the ability for it to be optional.
This commit changes things around to avoid using `Ember.inject.service`
and instead uses `getOwner(this).lookup('service:i18n')` (which returns
`undefined` if the service is not found).
|
Thanks for the PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an object that utilizes an
Ember.inject.service()is looked up the first time, Ember's DI system confirms that the service being injected is actually present and known to the system. If the service is not present it throws an error.In the use case of this addon,
i18nis intended to be an optional service and may not be present. If we useEmber.inject.service()in this context we loose the ability for it to be optional.This commit changes things around to avoid using
Ember.inject.serviceand instead usesgetOwner(this).lookup('service:i18n')(which returnsundefinedif the service is not found).