-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new Settings for migration when assignee users don't exist and S3 isn't used for attachment storage #102
base: master
Are you sure you want to change the base?
Conversation
…load, saving issue attachments locally, and rewriting attachment URLs in issue content. Fixed problem downloading attachments with international characters by encoding attachment download URIs.
Very cool commit. I have a few notes from my side if I could:
|
@@ -108,6 +120,10 @@ If this is set to true (default) then the migration process will transfer merge | |||
|
|||
As default it is set to false. Doesn't fire the requests to github api and only does the work on the gitlab side to test for wonky cases before using up api-calls | |||
|
|||
#### clearIssueAssignment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe would be better to have two commits:
- One commit for keepLocal+overrideURL+useSe
- Another commit for
clearIssueAssignment
) { | ||
// Get GitHub username from settings | ||
props.assignees.push(settings.usermap[pullRequest.assignee.username]); | ||
if (pullRequest.assignee){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The space character removed between ) {
... For cleaner commit would be better to keep original formatting
@bensons Any comments regarding the review? |
I've used the code in this PR to transfer the images to a hidden ref in the repo and use a relative link to have them show up in the issues, i.e. something like Since the PR does not merge cleanly anymore, here is an up-to-date version if it helps anyone (I don't have time right now to clean it up and submit a proper PR): master...phil-blain:fixes. The only thing I did not reapply is the I've also removed the use of the |
Created settings for clearing issue assignees, bypassing S3 bucket upload, saving issue
attachments locally, and rewriting attachment URLs in issue content. Fixed problem downloading
attachments with international characters by encoding attachment download URIs.