Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cert parsing for ios 12 #1822

Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix cert parsing for ios 12 #1822

merged 1 commit into from
Nov 10, 2023

Conversation

darkang3lz92
Copy link
Contributor

@darkang3lz92 darkang3lz92 commented Oct 5, 2023 •
edited
Loading

Connection with issue(s)

Resolve issue #524

Connected to #631

Testing and Review Notes

Build and run in iOS 12 with HTTPS site, expected to stop triggering ASN1ParseError and properly retrieve value from getCertificate.

Screenshots or Videos

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers

@pichillilorenzo pichillilorenzo merged commit 98ff3e5 into pichillilorenzo:master Nov 10, 2023
@pichillilorenzo
Copy link
Owner

@all-contributors please add @darkang3lz92 for code

@allcontributors allcontributors bot mentioned this pull request Nov 10, 2023
Merged
@allcontributors AllContributors
Copy link
Contributor

@pichillilorenzo

I've put up a pull request to add @darkang3lz92! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkang3lz92 @pichillilorenzo