- added a shared WKProcessPool for webview instances #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
Resolve issue #196, #152
Testing and Review Notes
We discovered that CookieManager fails to set cookies on iOS 11 and on iOS 12 it's working only before you are opening a webview. After that, if you want to set again some new cookies, the cookie store doesn't take care of them.
After hours of searches, we found out that there is a bug on older iOS versions and you need to use a shared WKProcessPool for your webviews - https://link.medium.com/VUNloIbpI1 https://forums.developer.apple.com/thread/99674.
Screenshots or Videos
To Do