Add privacy manifest for iOS #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#2028 5 minutes apart :) |
when this pr can be confirmed |
|
@pichillilorenzo please confirme |
balajiks-dev
reviewed
Apr 9, 2024
| @@ -0,0 +1,14 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Can you please let me know how to test this PR?
There was a problem hiding this comment.
Unfortunately, there's no real way to test this.
The only way I can think of, is to build an app that just uses this as a dependency and submit it to review in App Store Connect and see whether you get an email complaining about this
Upgrade OrderedSet to add privacy manifest
|
@all-contributors please add @ueman for code |
|
I've put up a pull request to add @ueman! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
Resolve issue #1909
This adds an empty privacy manifest. I could not find this library using any of the listed methods from https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api
This is similar to the changes seen in the first party Flutter plugins #1909
Testing and Review Notes
I'm not really sure how to test this. I guess if this builds it's fine?