Consider that browsers might not be supported by devices #2070
+66
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EArminjon
reviewed
Mar 19, 2024
flutter_inappwebview_android/android/gradle/wrapper/gradle-wrapper.properties
Outdated
Show resolved
Hide resolved
komaxx
reviewed
Jul 31, 2024
| ///{@template flutter_inappwebview_platform_interface.PlatformChromeSafariBrowser.onBrowserNotSupported} | ||
| /// Called when the browser is not supported. | ||
| /// This can happen if a user forces a certain browser package to be used but the browser is not installed on the user's system. | ||
| void onBrowserNotSupported() { |
There was a problem hiding this comment.
I guess there needs to be an {@endtemplate} here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try catch ClassNotFoundException exceptions when opening activity for intent
Resolve issue #2055
Testing and Review Notes
The problem it solves is a crash on devices without Chrome when explicitly calling the ChromeSafari with the chrome package on Android. I would like to be able to show the users at least a dialog that the browser they are using is not supported and that they should make sure to install Chrome.
Consider this as draft as I was not able to test it.
The project relies on old dependencies (flutter_inappwebview_platform_interface 1.0.10 instead of 1.0.11) so this is untested and also not clear if I miss places that need to be considered.