Fixes CVE-2020-6563 #2243
Draft
Fixes CVE-2020-6563 #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think that this is still necessary? |
Yes it is, but it should somehow follow the defined provided path in the resource file. I haven't got time to investigate whether we can link them together. |
|
Do you have an example of an input and its expected output that your code should return? Something to test it with, thanks! |
|
Ah I used to have one, but it looks expired :( |
|
I think attachments in https://issues.chromium.org/issues/40052821#c_ts1596465909 should be able to reproduce the issue. Also https://bugzilla.mozilla.org/show_bug.cgi?id=1652360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request resolves CVE-2020-6563 which allows the file provider to access files in the sandbox by explicitly checking the file path and excluding potential results.