added automaticallyAdjustsScrollIndicatorInsets option to ios #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tokonu and thanks a lot for your support! However, I have already added this option to |
pichillilorenzo
added a commit
that referenced
this pull request
Dec 16, 2019
This was referenced Jul 6, 2020
Closed
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
Connected to #210
Testing and Review Notes
As mentioned in the issue, on notched iphones running ios 13+, scroll bar of the webview is displayed in the middle of the screen. This issue is also mentioned in flutter/flutter#41592.
A fix was proposed in flutter/plugins#2343. As seen in this fix I added automaticallyAdjustsScrollIndicatorInsets option to IosInAppWebViewOptions. This is not a breaking change since the default value is true; nothing changes if this option is not set to false.
Also I changed a forced unwrapping because I encountered a crash.