Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when prompt was called on Android Q. #263

Merged
merged 1 commit into from
May 9, 2020
Merged

Fix crash when prompt was called on Android Q. #263

merged 1 commit into from
May 9, 2020

Conversation

AlexV525
Copy link
Contributor

Connection with issue(s)

Connected to #261 .

Testing and Review Notes

  1. Visit a web page included window.prompt (e.g. https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_prompt).
  2. Call window.prompt then the app crashed.

To Do

  • test with more cases

@arnaudelub
Copy link

If you want, as the maintainer is out for quite a long time now, we are maintaining this fork:
https://github.com/arnaudelub/flutter_polywebview
package also available on pub.dev:
https://pub.dev/packages/flutter_polywebview

feel free to add you PR on this fork if you want.

@pichillilorenzo pichillilorenzo merged commit 13b9d80 into pichillilorenzo:master May 9, 2020
@AlexV525 AlexV525 deleted the fix-crash-when-prompt-called-on-android-q branch May 9, 2020 05:38
This was referenced Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants