Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] encode resourceURL #27

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Conversation

igtm
Copy link
Contributor

@igtm igtm commented Dec 18, 2018

What is the problem?

2018-12-18 16 29 56

a Fatal error occurs when a resource url has some unescaped characters which must be escaped before unwrapping.
For example, https://fonts.googleapis.com/css?family=Google+Sans:400,500|Roboto:300,400,500|Roboto+Mono:400,700|Material+Icons.

I encounted the error when I tried to run the InAppBrowser example code.

What is my solution?

encoding urls before unwrapping.

my environment

Flutter 1.1.2-pre.39 • channel master • https://github.com/flutter/flutter.git
Framework • revision 0e9ad43416 (34 hours ago) • 2018-12-16 16:39:28 -0500
Engine • revision 4941125829
Tools • Dart 2.2.0 (build 2.2.0-dev.1.1 f9ebf21297)

@pichillilorenzo
Copy link
Owner

Thanks! I will merge it as soon as possible! Before I need to review another pull request and then I will merge this one 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants