Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add android media intents on wildcard input accept #620

Conversation

cbodin
Copy link
Contributor

@cbodin cbodin commented Dec 10, 2020

Connection with issue(s)

Resolve issue #596

Connected to #596

Testing and Review Notes

  1. Use the InAppWebView in an app with camera permissions.
  2. Open a webpage with an <input type="file"> (no accept attribute) in the InAppWebView.
  3. The intent chooser should be shown with photo, video and file intents.

The following HTML can be used to test different accept parameters:

<label>accept image/jpeg<input type="file" accept="image/jpeg"></label><br>
<label>accept video/mp4<input type="file" accept="video/mp4"></label><br>
<label>accept */*<input type="file" accept="*/*"></label><br>
<label>no accept (infers */*)<input type="file"></label>

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers

@cbodin cbodin changed the title Fix/add android media intents on wildcard input accept WIP: Fix/add android media intents on wildcard input accept Dec 10, 2020
@cbodin cbodin changed the title WIP: Fix/add android media intents on wildcard input accept Fix/add android media intents on wildcard input accept Dec 10, 2020
@cbodin cbodin marked this pull request as ready for review December 10, 2020 20:08
@cbodin cbodin changed the title Fix/add android media intents on wildcard input accept Add android media intents on wildcard input accept Dec 14, 2020
@pichillilorenzo
Copy link
Owner

Thanks for the fix! 😄 👍

@pichillilorenzo pichillilorenzo merged commit 179ef63 into pichillilorenzo:master Jan 28, 2021
@cbodin cbodin deleted the fix/add-android-media-intents-on-wildcard-input-accept branch September 27, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants