Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the documentation by @moneybird, the refresh token should be persisted in all cases. This is not possible with the current implementation.
It's a bit unclear to me whether the access token can actually expire, since I was not able to retrieve an
expires_in
. In any case we should be able to persist the refresh just in case.Another small change here is making the
getAuthUrl
public since we then could use framework methods for redirecting, e.g. in Laravel:return redirect($connection->getAuthUrl());
.