Feature/addattachment #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephangroen
reviewed
Jul 9, 2018
| 'multipart' => [ | ||
| [ | ||
| 'name' => 'file', | ||
| 'contents' => fopen($file, 'r'), |
There was a problem hiding this comment.
I think we should just pass the file contents to the addAttachment method. This way anyone who implements it has their own choice of how to get the contents. For example if someone has contents in a database, they would query it and pass it to the method.
There was a problem hiding this comment.
Sounds reasonable. I will change it to do that.
|
Would love this feature! Can this be merged? :) |
This will support anything, and not only files.
|
Thanks for the change @derkgort :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to upload/add an attachment to an SalesInvoice.
This is mostly heavily inspired by the change suggested by @dannyvw in #102. New issue: #157