Support changing estimate state #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating an estimate, changing it's state is not allowed and silently ignored. Changing the state of an estimate requires a separate API call. The method added exposes this endpoint through the PHP Client.
|
Sorry about the formatting issues, I have fixed them. |
|
This would fix #250 |
|
@MultiSuperFreek out of curiosity: what if Moneybird adjusts the validation? So then the package has to be updated again first to match this server-side validation? |
|
@robindirksen1 After checking with my colleague we've confirmed that Moneybird already returns a 400 Bad Request when an invalid state is given (I was under the impression this was not the case, and the API returned an new Estimate with the given state ignored), so this validation does little more then increasing maintenance burden. I'll remove the client side check! |
|
LGTM ✅ @stephangroen or @sanderlissenburg, can you take a look at this PR? |
robindirksen1
approved these changes
Nov 2, 2023
stephangroen
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating an estimate, changing it's state is not allowed and silently ignored. Changing the state of an estimate requires a separate API call. The method added exposes this endpoint through the PHP Client.