Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow contact people to be managed #290

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

rojtjo
Copy link
Contributor

@rojtjo rojtjo commented Nov 20, 2023

Allow creating, updating and removing contact people.

We might want to consider renaming ContactPeople to ContactPerson in a future major release since it's the only entity where the name is pluralized.

@rojtjo rojtjo force-pushed the feature/manage-contact-people branch from b71e067 to 36a6590 Compare November 20, 2023 14:32
@rojtjo
Copy link
Contributor Author

rojtjo commented Jan 29, 2024

@stephangroen Could you review this PR whenever you have some spare time?

@stephangroen
Copy link
Member

Thanks @rojtjo. Agree with the rename in the future.

@stephangroen stephangroen merged commit 0e8960d into picqer:main Jan 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants