Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FinancialMutation::linkToBooking() #85

Merged

Conversation

holtkamp
Copy link
Contributor

@holtkamp
Copy link
Contributor Author

holtkamp commented Apr 11, 2017

@stephangroen I had a look at the current approach to testing, it seems no mocking of the Moneybird API is done? Not that I would know how to do it 😉, I had some encounters with it in this project, any ideas / plans on how to mock the Moneybird API? (thinking of a MockingBird... 🐦 )

UPDATE
I gave it a shot and some initial testing using a mocked connection as explained here is added.

@holtkamp
Copy link
Contributor Author

@stephangroen anything missing to merge this?

@stephangroen
Copy link
Member

@holtkamp Looks quite nice! Currently no mocking of the API is done, only the verification if the entities are instantiable, so no code errors/typos exist. Your solution is a very nice addition for completer testing. Thanks!

@stephangroen stephangroen merged commit 8cf6cfb into picqer:master May 8, 2017
@holtkamp holtkamp deleted the patch-FinancialMutation-LinkBooking branch May 8, 2017 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants