0.4.1 #282
Merged
0.4.1 #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update adds the `!default` modifier to all defined defaults in `_variables.scss`. This allows for the user to redefine the base variables via import rather than having to patch or completely override the file. E.g.,: ```scss $primary-color: red; @import 'spectre' ```
Add default modifier to all variables
Typo, LESS is now SCSS
houndci-bot
reviewed
Sep 11, 2017
| height: auto; | ||
| max-width: 100%; | ||
| width: 100%; | ||
| video.video-responsive { |
There was a problem hiding this comment.
Avoid qualifying class selectors with an element.
| } | ||
|
|
||
| summary.accordion-header { | ||
| &::-webkit-details-marker { |
There was a problem hiding this comment.
Begin pseudo classes with a single colon: :
| } | ||
| } | ||
|
|
||
| summary.accordion-header { |
There was a problem hiding this comment.
Avoid qualifying class selectors with an element.
| max-height: 0; | ||
| overflow: hidden; | ||
| transition: max-height .2s ease; | ||
| .icon { |
There was a problem hiding this comment.
Selector should have depth of applicability no greater than 2, but was 3
| .icon { | ||
| transition: all .2s ease; | ||
| } | ||
| & .accordion-body { |
| input:checked ~, | ||
| &[open] { | ||
| & .accordion-header { | ||
| .icon { |
There was a problem hiding this comment.
Selector should have depth of applicability no greater than 2, but was 3
| } | ||
| input:checked ~, | ||
| &[open] { | ||
| & .accordion-header { |
docs/src/docs.scss
Outdated
|
|
||
| &[data-lang="Bash"] { | ||
| .tag { | ||
| user-select: none; |
There was a problem hiding this comment.
Properties should be ordered margin-right, user-select
| @@ -206,6 +205,13 @@ | |||
| .atv { | |||
| color: #e06870; | |||
| } | |||
|
|
|||
| &[data-lang="Bash"] { | |||
| .tag { | |||
There was a problem hiding this comment.
Selector should have depth of applicability no greater than 2, but was 3
| @@ -41,6 +39,7 @@ | |||
| font-weight: 600; | |||
| text-transform: uppercase; | |||
| } | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressreset which changes font-style to normal Add <address> support #270