Skip to content
This repository has been archived by the owner on Mar 7, 2023. It is now read-only.

Specific Delegate Methods #103

Merged
merged 8 commits into from
Mar 26, 2014
Merged

Conversation

jrmsklar
Copy link

Added specific delegate methods so that the user of PBJVision can respond to specific changes to the camera. Prior to this change, the user would have needed to implement visionModeWillChange: or visionModeDidChange:, and respond to changes to multiple different camera settings within that one method, such as:

  • Changing the camera device (front/back)
  • Changing the camera mode (photo/video)
  • Changing the output format (preset/square/widescreen)

I've added numerous new delegate methods:

- (void)visionCameraDeviceWillChange:(PBJVision*)vision;
- (void)visionCameraDeviceDidChange:(PBJVision*)vision;

- (void)visionCameraModeWillChange:(PBJVision*)vision;
- (void)visionCameraModeDidChange:(PBJVision*)vision;

- (void)visionOutputFormatWillChange:(PBJVision*)vision;
- (void)visionOutputFormatDidChange:(PBJVision*)vision;

so that the user of this class can respond to each individual action.

piemonte added a commit that referenced this pull request Mar 26, 2014
@piemonte piemonte merged commit c8a1dbb into piemonte:master Mar 26, 2014
@piemonte
Copy link
Owner

Great additions, thanks for contributing! 👍

@jrmsklar
Copy link
Author

Thanks for merging @piemonte! Would you mind updating Cocoapods with this new addition?

@jrmsklar jrmsklar deleted the more-delegate-methods branch March 26, 2014 13:57
@piemonte
Copy link
Owner

Yeah, not a problem.

CocoaPods/Specs#9765

@manans25
Copy link

manans25 commented Sep 6, 2015

Hello guys,

I was trying to play with the widescreen setting. If I wanted to change the size of the output video to a smaller width and height, I have been able to do it. However, the captured video is cropped in the output video. Is there a specific method I need to implement or make a change in a specifc file to ensure that the video capture size matches the final output video render size?

Thanks for your help.

@manans25
Copy link

manans25 commented Sep 6, 2015

So the question really is how to change the screen size and the square preview that we see when recording the video?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants