Fix bufferSizeInSeconds Not Affecting preferredForwardBufferDuration #257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of a playback stall (as shown below), the interrupted player will wait for the buffer to catch up before resuming playback. The "safe" amount of buffer headroom is supposed to be configurable.
Previously,
bufferSizeInSeconds
had no effect onpreferredForwardBufferDuration
, causing the player to wait a long time for a large, Apple-configured buffer headroom value. It should instead adhere to thebufferSizeInSeconds
configuration in thePlayer
class. This PR fixes the issue.