Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bufferSizeInSeconds Not Affecting preferredForwardBufferDuration #257

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

w43322
Copy link
Contributor

@w43322 w43322 commented Dec 8, 2024

In the case of a playback stall (as shown below), the interrupted player will wait for the buffer to catch up before resuming playback. The "safe" amount of buffer headroom is supposed to be configurable.

{
  "transportType" : "HTTP Progressive Download",
  "mediaType" : "HTTP Progressive Download",
  "BundleID" : "RedGift",
  "name" : "MEDIA_PLAYBACK_STALL",
  "interfaceType" : "Loopback"
}

Previously, bufferSizeInSeconds had no effect on preferredForwardBufferDuration, causing the player to wait a long time for a large, Apple-configured buffer headroom value. It should instead adhere to the bufferSizeInSeconds configuration in the Player class. This PR fixes the issue.

@piemonte piemonte merged commit 59fa302 into piemonte:main Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants