Merge pull request #2 from pier-digital/f/DNX-2347/fix-transformers-g…

…et-params

Small fix to transformer get params

pier_ds_utils/transformer.py

@@ -171,8 +171,8 @@ def from_dict(cls, intervals: typing.Dict, **kwargs):
 
     def get_params(self, deep: bool = True) -> dict:
         return {
-            'intervals': self.labels_,
-            'labels': self.intervals_,
+            'intervals': self.intervals_,
+            'labels': self.labels_,
             'default_value': self.default_value_,
             'output_column': self.output_column_,
             'column': self.column_,

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "pier-ds-utils"
-version = "0.2.1"
+version = "0.2.2"
 description = "The pier_ds_utils is an internal library used by data science teams to avoid code duplication in common tasks."
 authors = ["caiodallaqua <caio.leal@pier.digital>"]
 readme = "README.md"

tests/test_transformer.py

@@ -52,6 +52,28 @@ def test_custom_discrete_categorizer():
     ]
 
 
+def test_custom_discrete_categorizer_get_params():
+    categories = [
+        ['M', 'm', 'Masculino', 'masculino'],
+        ['F', 'f', 'Feminino', 'feminino'],
+    ]
+    labels = ['M', 'F']
+    default_value = 'M'
+
+    categorizer = ds.transformer.CustomDiscreteCategorizer(
+        column='gender',
+        categories=categories,
+        labels=labels,
+        default_value=default_value,
+    )
+
+    params = categorizer.get_params()
+
+    assert params['categories'] == categories
+    assert params['labels'] == labels
+    assert params['default_value'] == default_value
+
+
 def test_custom_interval_categorizer():
     categorizer = ds.transformer.CustomIntervalCategorizer(
         column='price',
@@ -98,6 +120,36 @@ def test_custom_interval_categorizer():
         'fx_outras_marcas',
     ]
 
+
+def test_custom_interval_categorizer_get_params():
+    column = 'price'
+    intervals = [
+        (498, 2700),
+        (2700, 3447.6),
+        (3447.6, 5592),
+        (5592, 13950),
+    ]
+    labels = ['fx1_apple', 'fx2_apple', 'fx3_apple', 'fx4_apple']
+    default_value = 'fx_outras_marcas'
+    output_column = 'price_fx'
+
+    categorizer = ds.transformer.CustomIntervalCategorizer(
+        column=column,
+        intervals=intervals,
+        labels=labels,
+        default_value=default_value,
+        output_column=output_column,
+    )
+
+    params = categorizer.get_params()
+
+    assert params['column'] == column
+    assert params['intervals'] == intervals
+    assert params['labels'] == labels
+    assert params['default_value'] == default_value
+    assert params['output_column'] == output_column
+
+
 def test_custom_interval_categorizer_by_category():
     categorizer = ds.transformer.CustomIntervalCategorizerByCategory(
         category_column='brand',