Skip to content

Commit

Permalink
Remove limits from kafka broker dispatcher (knative-extensions#1091)
Browse files Browse the repository at this point in the history
  • Loading branch information
creydr authored May 15, 2024
1 parent 7acc3dd commit 56235ea
Show file tree
Hide file tree
Showing 6 changed files with 42 additions and 26 deletions.
3 changes: 0 additions & 3 deletions data-plane/config/broker/500-dispatcher.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,6 @@ spec:
cpu: 1000m
# 600Mi for virtual replicas + 100Mi overhead
memory: 700Mi
limits:
cpu: 2000m
memory: 1000Mi

livenessProbe:
failureThreshold: 3
Expand Down
3 changes: 0 additions & 3 deletions data-plane/config/brokerv2/500-dispatcher.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,6 @@ spec:
cpu: 1000m
# 600Mi for virtual replicas + 100Mi overhead
memory: 700Mi
limits:
cpu: 2000m
memory: 1000Mi

livenessProbe:
failureThreshold: 3
Expand Down
42 changes: 42 additions & 0 deletions openshift/patches/remove_dispatcher_limits.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
diff --git a/data-plane/config/source/500-dispatcher.yaml b/data-plane/config/source/500-dispatcher.yaml
index 2aa7a9ebd..29be6c357 100644
--- a/data-plane/config/source/500-dispatcher.yaml
+++ b/data-plane/config/source/500-dispatcher.yaml
@@ -125,9 +125,6 @@ spec:
cpu: 1000m
# 600Mi for virtual replicas + 100Mi overhead
memory: 700Mi
- limits:
- cpu: 2000m
- memory: 1000Mi

livenessProbe:
failureThreshold: 3
diff --git a/data-plane/config/broker/500-dispatcher.yaml b/data-plane/config/broker/500-dispatcher.yaml
index ea12c2820..9540f412a 100644
--- a/data-plane/config/broker/500-dispatcher.yaml
+++ b/data-plane/config/broker/500-dispatcher.yaml
@@ -128,9 +128,6 @@ spec:
cpu: 1000m
# 600Mi for virtual replicas + 100Mi overhead
memory: 700Mi
- limits:
- cpu: 2000m
- memory: 1000Mi

livenessProbe:
failureThreshold: 3
diff --git a/data-plane/config/brokerv2/500-dispatcher.yaml b/data-plane/config/brokerv2/500-dispatcher.yaml
index 27d9ecc44..cc393e793 100644
--- a/data-plane/config/brokerv2/500-dispatcher.yaml
+++ b/data-plane/config/brokerv2/500-dispatcher.yaml
@@ -128,9 +128,6 @@ spec:
cpu: 1000m
# 600Mi for virtual replicas + 100Mi overhead
memory: 700Mi
- limits:
- cpu: 2000m
- memory: 1000Mi

livenessProbe:
failureThreshold: 3
14 changes: 0 additions & 14 deletions openshift/patches/remove_source_limits.patch

This file was deleted.

3 changes: 0 additions & 3 deletions openshift/release/artifacts/eventing-kafka-broker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -413,9 +413,6 @@ spec:
cpu: 1000m
# 600Mi for virtual replicas + 100Mi overhead
memory: 700Mi
limits:
cpu: 2000m
memory: 1000Mi

livenessProbe:
failureThreshold: 3
Expand Down
3 changes: 0 additions & 3 deletions openshift/release/artifacts/eventing-kafka.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3769,9 +3769,6 @@ spec:
cpu: 1000m
# 600Mi for virtual replicas + 100Mi overhead
memory: 700Mi
limits:
cpu: 2000m
memory: 1000Mi

livenessProbe:
failureThreshold: 3
Expand Down

0 comments on commit 56235ea

Please sign in to comment.