forked from elastic/elasticsearch
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix SO-Error in SearchWithRandomDisconnectsIT (elastic#122593)
Obvious SO exception possibilitiy if we encounter exceptions back to back in the callback. Use promise style pattern instead of callback in the individual loops to limit stack-depth (this should be good enough for a fix, technically you could still run into very deep stacks if the search completes between the `isDone` check and adding the listener back-to-back a couple times but practically this should be good enough since all the instant-done situations are from the search fully failing outright. closes elastic#116175
- Loading branch information
1 parent
95f8454
commit fd25d3b
Showing
2 changed files
with
9 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters