Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8 & Fix #15: Added error handling for invalid image format and face detection logic #21

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

elliotverstraelen
Copy link
Collaborator

This pull request addresses issue #8 by adding the following changes:

  1. Error Handling for Invalid Image Format:

    • Added a detect_faces function to handle face detection and potential errors.
    • Included specific handling for InvalidImageFormatException.
  2. Updated Session State Management:

    • Utilized SessionRepository to manage session states more efficiently.
    • Added new states for error handling (error-detecting-selfie-faces, error-detecting-student-id-faces, more-than-one-face).

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kys ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 1:10pm

@elliotverstraelen elliotverstraelen changed the title Fix #8: Added error handling for invalid image format and face detection logic Fix #8 & Fix #15: Added error handling for invalid image format and face detection logic May 20, 2024
@volesen
Copy link
Collaborator

volesen commented May 20, 2024

LGTM, is this ready to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants