feat(auth, core, home, user): improve signin/up & navigation bar style ✨#447
Merged
PierreBrisorgueil merged 1 commit intopierreb-devkit:masterfrom Jun 29, 2022
PierreBrisorgueil:SimplifyLoginToNewStandards
Merged
feat(auth, core, home, user): improve signin/up & navigation bar style ✨#447PierreBrisorgueil merged 1 commit intopierreb-devkit:masterfrom PierreBrisorgueil:SimplifyLoginToNewStandards
PierreBrisorgueil merged 1 commit intopierreb-devkit:masterfrom
PierreBrisorgueil:SimplifyLoginToNewStandards
Conversation
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| self.navigationController?.navigationBar.scrollEdgeAppearance = UINavigationBarAppearance().then { | ||
| $0.backgroundColor = Metric.primary?.withAlphaComponent(0.9) | ||
| $0.titleTextAttributes = [.foregroundColor: Metric.onPrimary!] | ||
| if Metric.navigationBarTransparent == true { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| self.navigationController?.navigationBar.scrollEdgeAppearance = UINavigationBarAppearance().then { | ||
| $0.backgroundColor = Metric.primary?.withAlphaComponent(0.9) | ||
| $0.titleTextAttributes = [.foregroundColor: Metric.onPrimary!] | ||
| if Metric.navigationBarTransparent == true { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| $0.configureWithTransparentBackground() | ||
| $0.titleTextAttributes = [.foregroundColor: Metric.onPrimary!] | ||
| } | ||
| let defaultNavigationBar = UINavigationBarAppearance().then { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| $0.configureWithTransparentBackground() | ||
| $0.titleTextAttributes = [.foregroundColor: Metric.onPrimary!] | ||
| } | ||
| let defaultNavigationBar = UINavigationBarAppearance().then { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit 7d8f7a0 and detected 10 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
PierreBrisorgueil
pushed a commit
that referenced
this pull request
Jun 30, 2022
# [1.2.0](v1.1.0...v1.2.0) (2022-06-30) ### Bug Fixes * **lib:** protect from non jwt cookies 🐛 ([#448](#448)) ([fa05892](fa05892)) * Gemfile & Gemfile.lock to reduce vulnerabilities ([#373](#373)) ([3ed2510](3ed2510)) * Gemfile & Gemfile.lock to reduce vulnerabilities ([#378](#378)) ([983c2cd](983c2cd)) * Gemfile & Gemfile.lock to reduce vulnerabilities ([#396](#396)) ([ab13293](ab13293)) * Gemfile & Gemfile.lock to reduce vulnerabilities ([#436](#436)) ([fcb7395](fcb7395)) * Gemfile & Gemfile.lock to reduce vulnerabilities ([#443](#443)) ([96036ac](96036ac)) * Gemfile.lock to reduce vulnerabilities ([#424](#424)) ([0f58fcb](0f58fcb)) * **core:** add option to handle navigation shadow 🐛 ([#425](#425)) ([1ed4de1](1ed4de1)) * **helper:** uibutton circle fix 🐛 ([#419](#419)) ([4a326e2](4a326e2)) ### Features * **auth, core, home, user:** improve signin/up & navigation bar style ✨ ([#447](#447)) ([9aba6ef](9aba6ef)) * **dependencies:** end upgrade ✨ ([#416](#416)) ([6737559](6737559)) * **global:** clean navigation bar option ✨ ([#426](#426)) ([e2403b3](e2403b3)) * **global:** dependencies upgrade ✨ ([#450](#450)) ([8a40e91](8a40e91))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.