Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are you still working on this? #1

Open
miguelcarcamov opened this issue Aug 15, 2019 · 4 comments
Open

Are you still working on this? #1

miguelcarcamov opened this issue Aug 15, 2019 · 4 comments

Comments

@miguelcarcamov
Copy link

Hi there,

I am interested on working with this API since it is very useful for my thesis work. Do you know if the functions are compatible with CUDA 10?

Best regards

@pierrepaleo
Copy link
Owner

Hi @miguelcarcamov

This project has not been updated for a while, but as far as I know things are working.
I just tested the code on a machine with CUDA 10 and all pypwt tests passed.

You will certainly need to modify the -arch compilation flag in PDWT/Makefile or pypwt/setup.py. For example I used -arch=sm_70 for a Tesla V100-SXM2.

The pypwt python wrapper runs numerous tests against the pywavelets module. However the API of pywavelets changed (notably for SWT), so tests fail with recent versions of pywavelets. The version 0.5.0 has to be used.

I tested the following with Python 3.6 in a virtual environment:

git clone https://github.com/pierrepaleo/pypwt
cd pypwt
# Modify the -arch compilation flag in setup.py depending on your device
python setup.py build
python setup.py install
pip install pywavelets==0.5.0 # see above comments 
python test/test_all.py

Tests have to be updated to compare against recent version of pywavelets.

@miguelcarcamov
Copy link
Author

what if I want to use it just in C++/CUDA? It should work despite my version of pywavelets right?

@lydiazajiczek
Copy link

lydiazajiczek commented Aug 15, 2019 via email

@pierrepaleo
Copy link
Owner

@miguelcarcamov Yes pywavelets is just for testing the Python wrapper, so the C++/CUDA API will work without it. What I meant is that if the Python tests pass, then the underlying C++/CUDA code should be valid. I also ran the bare demo of PDWT without issues.

@lydiazajiczek Thanks for the report ; would you be able to provide a minimal code reproducing this behavior ? As far as I remember, the only cases when I got these behaviors is when an illegal memory access is done on the image/coefficients (ex. buggy thresholding function).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants