Skip to content

Commit

Permalink
Bump version of miekg/dns to 1.0.4
Browse files Browse the repository at this point in the history
See hashicorp#3977

While trying to improve furthermore hashicorp#3948 (This pull request is still valid since we are not using Compression to compute the result anyway).

I saw a strange behaviour of dns library.
Basically, msg.Len() and len(msg.Pack()) disagree on Message len.

Thus, calculation of DNS response is false consul relies on msg.Len() instead of the result of Pack()

This is linked to miekg/dns#453 and a fix has been provided with miekg/dns#454

Would it be possible to upgrade miekg/dns to a more recent function ?

Consul might for instance upgrade to a post 1.0 release such as https://github.com/miekg/dns/releases/tag/v1.0.4
  • Loading branch information
pierresouchay committed Mar 21, 2018
1 parent 559d351 commit 7b8c42a
Show file tree
Hide file tree
Showing 260 changed files with 21,095 additions and 1,070 deletions.
1 change: 1 addition & 0 deletions vendor/github.com/miekg/dns/CONTRIBUTORS

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions vendor/github.com/miekg/dns/Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 26 additions & 0 deletions vendor/github.com/miekg/dns/Gopkg.toml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 33 additions & 0 deletions vendor/github.com/miekg/dns/Makefile.fuzz

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

52 changes: 52 additions & 0 deletions vendor/github.com/miekg/dns/Makefile.release

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 20 additions & 14 deletions vendor/github.com/miekg/dns/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 7b8c42a

Please sign in to comment.