Mojave updates #11
Open
Mojave updates #11
+29,902
−21,639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some optimizations
Update the icon (SVG edition)
While investigating gitx#17, I found that code pretty hard to understand. For the record, it built a set of OIDs while extracting the meaning of the `PBGitRevSpecifier`, which (since sets have no order) I suspected could cause the out-of-order behavior we had. Turns out the fix was much easier, but since I find this one cleaner, and less "loopy", here it is.
Fix missing parents
This is a bit more discoverable than double-clicking the submodule row.
There's a built-in NSBezierPath method for this now.
The app icon is in an asset catalog now.
…o make it easier to find them.
We can target just the public Quick Look API now (it has been public since 10.6).
Adjust strong and weak properties to ensure that PBGitRepository is retained by objects that are observing it with KVO. Otherwise PBGitRepository would get released before PBViewController subclasses that were observing it.
Broke retain cycle between PBGitCommitController and PBWebChangesController, and PBGitCommitController and PBCommitMessageView. PBCommitMessageView wasn't unregistering KVO of NSUserDefaults. PBFileChangesTableView was crashing because of nextKeyView and previousKeyView overrides. Instead set the next key views in the xib. The loop isn't quite the same, but it's close enough and eliminates memory leaks. Another way of setting the key view loop can be used if necessary.
Added "Open Submodule" menu item to contextual menu of submodules
Project cleanup
Fixed documents and repositories leaking when closing documents
That makes it map git error status to their real value
ObjectiveGit requires these for some reason.
A general directed attempt to reduce loadtimes
|
Could this be merged or looked at? Right now I cannot start the latest GitX on MacOS Mojave. |
|
error: gitx is not optimized for your mac. it seems that gitx is unusable on macOS 10.14 (Mojave) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.