Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoothness theme based on surface-tags #545

Open
tordans opened this issue Nov 5, 2021 · 4 comments
Open

Smoothness theme based on surface-tags #545

tordans opened this issue Nov 5, 2021 · 4 comments
Labels
Themes A new theme idea or improvement to an already existing theme

Comments

@tordans
Copy link
Collaborator

tordans commented Nov 5, 2021

I am thinking about creating a theme for a surface-quest based on https://wiki.openstreetmap.org/wiki/Berlin/Verkehrswende/smoothness

The theme would have to …

  • allow to add the surface tag based on a list of selected values
  • show different images (answers) for the smoothness-key based on the value of the surface tag
  • show the images + image-text in a nice way
  • ideally allow to set check_date:smoothness=<Date> once the object has a smoothness-value (hide the answer otherwise), so we can check which data was already checked/updated and which is still to do.
    • ideally with a "today"-quicklink to add the current date in the right format.

Any thought on this?
And any hints towards which parts of this requirements are also possible or maybe which theme does something similar would be very welcome.


This topic is also discussed in streetcomplete/StreetComplete#3257 (and originally in streetcomplete/StreetComplete#1630) and our meetup https://wiki.openstreetmap.org/wiki/Berlin/Verkehrswende.

@pietervdvn
Copy link
Owner

Hi Tobias,

Yes, this is all very possible to do - even quite easy.

If you haven't made a theme before, start reading these docs

Every tagrendering is a snippet of HTML. You can style it there, have a look at the bicycle parking theme which uses embedded images. Alternatively (if you feel up to the challenge), you can add an image option to the tagrendering format and make a fancy UI for them - this would be a great step to mimic StreetComplete.

Also, do have a look at the 'cycle-infra' theme. It has road surface and smoothness already - albait not very fancy.

Improving this theme would be your best bet, as it is already very advanced but still lacks some support for left and right cycleways. This tagging is suppported since short and would be a huge benefit. Only this sidewalk theme uses it for now.

At last, the gyroscope could be used to measure actual smoothness. A custom input element could be made for this, as HTML5 has an API forr this.

@matkoniecz
Copy link
Contributor

@pietervdvn What you think about streetcomplete/StreetComplete#3592 - idea of sharing smothness/surface images and pulling definitions from third-party repository?

(usefulness of this idea depends on whether anyone except SC would be using this repository)

@pietervdvn
Copy link
Owner

We already have such a shared repository - it is called "the OpenStreetMap wiki". We can do this by defining these entries in the underlying wikdiata-entity to make them machine-readable: https://wiki.openstreetmap.org/wiki/Item:Q706.

@tordans
Copy link
Collaborator Author

tordans commented Dec 16, 2021

Edit: Moved to streetcomplete/StreetComplete#3592 (comment)

@riQQ riQQ added the Themes A new theme idea or improvement to an already existing theme label Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Themes A new theme idea or improvement to an already existing theme
Projects
None yet
Development

No branches or pull requests

4 participants